nginx-gateway-fabric icon indicating copy to clipboard operation
nginx-gateway-fabric copied to clipboard

Add support to provision Gateway on Helm install

Open ciarams87 opened this issue 1 year ago • 5 comments
trafficstars

Proposed changes

Problem: As a user of NGF, I would like to be able to deploy a Gateway resource as part of my Helm installation

Solution: Add support for creating a Gateway resource as part of a Helm install.

Testing: Tested locally installing various Gateway configurations using Helm

Closes #1533

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x] I have read the CONTRIBUTING doc
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have checked that all unit tests pass after adding my changes
  • [x] I have updated necessary documentation
  • [x] I have rebased my branch onto main
  • [x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes, please add a brief note that summarizes the change.

Added support to provision a Gateway resource as part of a Helm install.

ciarams87 avatar Feb 28 '24 12:02 ciarams87

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.71%. Comparing base (f33db51) to head (482f7bc). Report is 176 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
+ Coverage   85.67%   85.71%   +0.03%     
==========================================
  Files          83       83              
  Lines        5181     5181              
==========================================
+ Hits         4439     4441       +2     
+ Misses        690      689       -1     
+ Partials       52       51       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 29 '24 12:02 codecov[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 15 '24 02:03 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 31 '24 02:03 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Apr 15 '24 03:04 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Apr 30 '24 02:04 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar May 15 '24 02:05 github-actions[bot]

This PR was closed because it has been stalled for 14 days with no activity.

github-actions[bot] avatar May 29 '24 02:05 github-actions[bot]