kubernetes-ingress icon indicating copy to clipboard operation
kubernetes-ingress copied to clipboard

#6679 add globalConfigurationCustomName parameter

Open frantsao opened this issue 1 year ago • 6 comments

Proposed changes

Add globalConfigurationCustomName parameter to controller confuguration in helm charts. It is helpful when the GlobalConfiguration is created separately from the helm provisioning, as explained in #6679

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [X] I have read the CONTRIBUTING doc
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] I have checked that all unit tests pass after adding my changes
  • [X] I have updated necessary documentation
  • [X] I have rebased my branch onto main
  • [X] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

frantsao avatar Oct 17 '24 15:10 frantsao

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Oct 17 '24 15:10 github-actions[bot]

I have hereby read the F5 CLA and agree to its terms

frantsao avatar Oct 17 '24 15:10 frantsao

Hi @frantsao,

I just tested this out, and it works well. Thanks again for working on it. There's one other thing that would be ideal: if the customName and create options could work together.

This would require an update to this file to use the name and namespace parts of the customName, if it exists.

The logic in _helpers.tpl would also need to be adjusted slightly to accommodate this change.

j1m-ryan avatar Nov 19 '24 17:11 j1m-ryan

Hi @frantsao,

I just tested this out, and it works well. Thanks again for working on it. There's one other thing that would be ideal: if the customName and create options could work together.

This would require an update to this file to use the name and namespace parts of the customName, if it exists.

The logic in _helpers.tpl would also need to be adjusted slightly to accommodate this change.

Ok, I think it's a good idea too, but I didn't know if the change could be interesting for you too. I'll work on it as soon as I have some free time again :-)

frantsao avatar Nov 19 '24 17:11 frantsao

Hi @frantsao, No worries at all, take your time. When you look at this again, you might find that making definitions in _helpers.tpl could be useful for getting the name and namespace defined. You can then use the defintions in the global configuration template file.

j1m-ryan avatar Nov 19 '24 17:11 j1m-ryan

Hi @j1m-ryan , I added the changes that we talked about previously. I hope it's what you expect :-)

frantsao avatar Dec 12 '24 14:12 frantsao

Fixed on https://github.com/nginx/kubernetes-ingress/pull/8142

danielnginx avatar Sep 02 '25 08:09 danielnginx