kubernetes-ingress icon indicating copy to clipboard operation
kubernetes-ingress copied to clipboard

make update-codegen fails but pipeline still passed

Open haywoodsh opened this issue 9 months ago • 1 comments

Describe the bug ./hack/update-codegen.sh return an error but pipeline is still passing.

In local environment it runs after fixing the permission issue but it removes the content of most files in pkg/client

To Reproduce Steps to reproduce the behavior:

```
./hack/update-codegen.sh
WARNING: generate-groups.sh is deprecated.
WARNING: Please use k[8](https://github.com/nginxinc/kubernetes-ingress/actions/runs/8817766289/job/24206399351#step:9:9)s.io/code-generator/kube_codegen.sh instead.

/home/runner/go/pkg/mod/k8s.io/[email protected][9](https://github.com/nginxinc/kubernetes-ingress/actions/runs/8817766289/job/24206399351#step:9:10).3/generate-groups.sh: line 66: /home/runner/go/pkg/mod/k8s.io/[email protected]/generate-internal-groups.sh: Permission denied
make: *** [Makefile:81: update-codegen] Error 126
```

See errors in https://github.com/nginxinc/kubernetes-ingress/actions/runs/8817766289/job/24206399351#step:9:12

Expected behavior Pipeline should fail if error message is produced

Your environment* This is failing on main.

In local environment, the repo must be cloned into ~/github.com/nginxinc/kubernetes-ingress. After running chmod +x chmod +x /Users/XXX/go/pkg/mod/k8s.io/[email protected]/generate-internal-groups.sh, it works as expected despite the warning message

WARNING: generate-groups.sh is deprecated.
WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead. 

Alternatives since generate-groups.sh is deprecated, we can try upgrading the package and use kube_codegen.sh as suggested by the warning message

haywoodsh avatar Apr 25 '24 14:04 haywoodsh

Hi @haywoodsh thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this :slightly_smiling_face:

Cheers!

github-actions[bot] avatar Apr 25 '24 14:04 github-actions[bot]

resolved by #5492

haywoodsh avatar May 07 '24 15:05 haywoodsh