kubernetes-ingress
kubernetes-ingress copied to clipboard
[Helm] Choose NodePort values for controller.service.type = LoadBalancer
Proposed changes
Closes related issue: https://github.com/nginxinc/kubernetes-ingress/issues/5333
This changes enable the possibility to choose custom NodePort port values when for controller.service.type = LoadBalancer.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
- [x] I have read the CONTRIBUTING doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have checked that all unit tests pass after adding my changes
- [x] I have updated necessary documentation
- [x] I have rebased my branch onto main
- [x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
Deploy request for nginx-kubernetes-ingress pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 4bb98829385c212e8da01f1006d737c9fcc0cab7 |
Hey @Falltrades this PR will be merged hopefully today but just a suggestion on branching please create a branch in the forked repo instead of using main for development for future contributions.
thanks again for the PR and apologies for the delay