kubernetes-ingress icon indicating copy to clipboard operation
kubernetes-ingress copied to clipboard

Evolve oidc logout

Open llomgui opened this issue 1 year ago • 12 comments

Proposed changes

Make sure the IDP is triggered during a logout.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [X] I have read the CONTRIBUTING doc
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [x] I have checked that all unit tests pass after adding my changes
  • [x] I have updated necessary documentation
  • [X] I have rebased my branch onto main
  • [X] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

llomgui avatar Jan 24 '24 22:01 llomgui

Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
Latest commit 91a9c124f97c15f50eabd1b9bb8279c62b19f70e

netlify[bot] avatar Jan 24 '24 22:01 netlify[bot]

Thank you @llomgui We will take a look and get back to you. We need to make sure your changes won't break anyone and are relatively generic to the core OIDC flow.

brianehlert avatar Jan 25 '24 17:01 brianehlert

Thank you @llomgui for submitting. Would it be possible for you to submit a GitHub issue to describe the situation you are trying to address. See CONTRIBUTING.md for a description of the issue submission process. There is also the scheduled community call where issues can be discussed.

pdabelf5 avatar Jan 26 '24 11:01 pdabelf5

Hello @pdabelf5, I created this issue to describe the current situation.

llomgui avatar Jan 26 '24 14:01 llomgui

Hi @llomgui,

We reviewed your issue and the team recommendation is to get the contents of your PR and port it into the Open ID connect reference implementation

danielnginx avatar Jan 29 '24 16:01 danielnginx

@danielnginx I will create a PR on this repository.

Do I have to close this one? I don't see any link with Kubernetes-ingress.

llomgui avatar Jan 29 '24 19:01 llomgui

@danielnginx Done https://github.com/nginxinc/nginx-openid-connect/pull/87

llomgui avatar Jan 30 '24 21:01 llomgui

@llomgui thank you. Once that PR is merged in the nginx-openid-connect, files should get copied over to https://github.com/nginxinc/kubernetes-ingress/tree/main/internal/configs/oidc via a PR. You can close this PR for now.

danielnginx avatar Jan 31 '24 09:01 danielnginx

@danielnginx The PR created on OIDC repository does not include operators changes. This PR needs to be merged.

llomgui avatar Jan 31 '24 12:01 llomgui

@llomgui you are right, we can leave this PR open. Once we get the nginx-openid-connect PR in we can update here.

danielnginx avatar Jan 31 '24 15:01 danielnginx

@danielnginx Do you have any news on this PR?

llomgui avatar Feb 23 '24 12:02 llomgui

@llomgui

As @danielnginx said, we can merge this PR as soon as your PR in the nginx-openid-connect repo is approved and merged.

If you need more visibility on PR, you can post about it in the public #nginx-users slack channel. The maintainers of the nginx-openid-connect repo frequently monitor that channel.

shaun-nx avatar Feb 28 '24 13:02 shaun-nx

Hello @llomgui, the nginx-openid-connect now includes support for OIDC logout, and our repository has been updated accordingly. We are keen to work with you to get this pull request merged. Could you align the OIDC files in your pull request with those in our kubernetes-ingress repository? Additionally, as we do not have integration tests for OIDC, I was wondering if you have attempted to deploy our OIDC example with logout, and if so, could you please outline the steps you followed so that I can do some testing on my side as well?

haywoodsh avatar Jul 22 '24 23:07 haywoodsh

Hi @llomgui, we are closing this PR and our team is taking over the https://github.com/nginxinc/kubernetes-ingress/issues/4989 implementation. You can follow the progress in the issue, we are working on it in our current sprint https://github.com/orgs/nginxinc/projects/2

danielnginx avatar Jul 23 '24 14:07 danielnginx