kubernetes-ingress
kubernetes-ingress copied to clipboard
Helm Chart: Add annotations to the service account in the Helm chart
Add annotations to pass with helm chart values.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR). The main idea is to have the ability to provide annotations to the service account. It may be useful in many cases. For example, according to this documentation, the service account should have the proper annotation when using the ingress controller with AWS Marketplace. Before this PR it was not possible to specify this annotation with the helm chart.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
- [x] I have read the CONTRIBUTING doc
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have checked that all unit tests pass after adding my changes
- [x] I have updated necessary documentation
- [x] I have rebased my branch onto main
- [x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@jasonwilliams14
Please see another update. I mentioned that values.yml
uses the unnecessary parameter includeYear
, preventing PODs from successfully starting.
I've tested it with 2.3.0
and 2.3.1
@0m1xa if you test it with edge
it shouldn't complain about includeYear
Codecov Report
Merging #3065 (b9f2b53) into main (bf67929) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #3065 +/- ##
==========================================
- Coverage 52.29% 52.28% -0.01%
==========================================
Files 58 58
Lines 15995 16006 +11
==========================================
+ Hits 8364 8369 +5
- Misses 7352 7358 +6
Partials 279 279
Impacted Files | Coverage Δ | |
---|---|---|
internal/k8s/controller.go | 11.10% <0.00%> (-0.02%) |
:arrow_down: |
cmd/nginx-ingress/main.go | 0.00% <0.00%> (ø) |
|
cmd/nginx-ingress/flags.go | 34.42% <0.00%> (ø) |
|
internal/configs/config_params.go | 76.74% <0.00%> (ø) |
|
internal/configs/version2/http.go | 0.00% <0.00%> (ø) |
|
internal/configs/version1/config.go | 0.00% <0.00%> (ø) |
|
internal/k8s/configuration.go | 95.39% <0.00%> (+<0.01%) |
:arrow_up: |
internal/configs/virtualserver.go | 95.22% <0.00%> (+<0.01%) |
:arrow_up: |
internal/configs/transportserver.go | 93.81% <0.00%> (+0.03%) |
:arrow_up: |
internal/configs/configmaps.go | 20.37% <0.00%> (+0.16%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more