kubernetes-ingress
kubernetes-ingress copied to clipboard
Feat/transport server external name
Proposed changes
Initial support for Transport Server external name including examples.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
- [X] I have read the CONTRIBUTING doc
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] I have checked that all unit tests pass after adding my changes
- [X] I have updated necessary documentation
- [X] I have rebased my branch onto main
- [X] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
Codecov Report
Merging #3041 (0186b91) into main (23be85f) will decrease coverage by
0.02%
. The diff coverage is23.80%
.
@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
- Coverage 52.31% 52.28% -0.03%
==========================================
Files 58 58
Lines 15995 16028 +33
==========================================
+ Hits 8368 8381 +13
- Misses 7350 7369 +19
- Partials 277 278 +1
Impacted Files | Coverage Δ | |
---|---|---|
cmd/nginx-ingress/flags.go | 34.42% <ø> (ø) |
|
cmd/nginx-ingress/main.go | 0.00% <0.00%> (ø) |
|
internal/configs/config_params.go | 76.74% <ø> (ø) |
|
internal/configs/configurator.go | 37.06% <0.00%> (-0.32%) |
:arrow_down: |
internal/configs/version1/config.go | 0.00% <ø> (ø) |
|
internal/configs/version2/http.go | 0.00% <ø> (ø) |
|
internal/k8s/controller.go | 11.07% <0.00%> (-0.05%) |
:arrow_down: |
internal/configs/configmaps.go | 20.37% <100.00%> (+0.16%) |
:arrow_up: |
internal/configs/transportserver.go | 97.48% <100.00%> (+3.70%) |
:arrow_up: |
internal/configs/virtualserver.go | 95.22% <100.00%> (+<0.01%) |
:arrow_up: |
... and 4 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Can we add a README for the new
externalname-services
example files?
It's WIP (work in progress)