kubernetes-ingress icon indicating copy to clipboard operation
kubernetes-ingress copied to clipboard

Add command line argument to manually disable IPV6 listeners for unsupported clusters

Open haywoodsh opened this issue 3 years ago • 1 comments
trafficstars

Proposed changes

Add command line argument to manually disable IPV6 listeners for clusters that support IPV4 only.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have checked that all unit tests pass after adding my changes
  • [x] I have updated necessary documentation
  • [x] I have rebased my branch onto main
  • [x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

haywoodsh avatar Sep 15 '22 08:09 haywoodsh

Codecov Report

Merging #3040 (85facf5) into main (fcd9808) will decrease coverage by 0.00%. The diff coverage is 45.45%.

@@            Coverage Diff             @@
##             main    #3040      +/-   ##
==========================================
- Coverage   52.31%   52.31%   -0.01%     
==========================================
  Files          58       58              
  Lines       15995    16006      +11     
==========================================
+ Hits         8368     8373       +5     
- Misses       7350     7356       +6     
  Partials      277      277              
Impacted Files Coverage Δ
cmd/nginx-ingress/flags.go 34.42% <ø> (ø)
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/k8s/controller.go 11.10% <0.00%> (-0.02%) :arrow_down:
internal/configs/configmaps.go 20.37% <100.00%> (+0.16%) :arrow_up:
internal/configs/transportserver.go 93.81% <100.00%> (+0.03%) :arrow_up:
internal/configs/virtualserver.go 95.22% <100.00%> (+<0.01%) :arrow_up:
internal/k8s/configuration.go 95.76% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 21 '22 10:09 codecov-commenter