docker-nginx icon indicating copy to clipboard operation
docker-nginx copied to clipboard

Use the smaller package envsubst

Open ajpaulson opened this issue 3 years ago • 1 comments

In the Dockerfile, gettext is installed, then removed just to get the envsubst binary. In the APK repos there is an envsubst package with just the 1 binary - could this be considered to neaten up the docker build?

ajpaulson avatar Apr 20 '22 12:04 ajpaulson

There is no envsubst package in the 3.14 or 3.15 version of Alpine yet. Maybe if/when it hits a newer release we can take a look at utilizing it instead of doing a gettext hack. Also, I'm not sure it's 100% compatible with GNU gettext version though and the project repo doesnt inspire much confidence: https://github.com/kaniini/envsubst

And another point is that I would like to keep both debian and alpine images as close as possible, and having different implementations of envsubst might introduce hard to diagnose issues.

thresheek avatar May 06 '22 08:05 thresheek

Will not implement due to concerns stated above.

thresheek avatar Oct 11 '22 07:10 thresheek