nginx-http-shibboleth icon indicating copy to clipboard operation
nginx-http-shibboleth copied to clipboard

Published 20 hours ago • verified publisher icon nginx-shib

Fix compatibility with nginx 1.23.0+

Open heikojansen opened this issue 2 years ago • 2 comments

This pull requests includes the same fixes I mentioned in issue #48 but with proper references to their origin in openresty/headers-more-nginx-module where they were created and contributed by other people.

Besides me a few other users of ngx_http_shibboleth independently verified that these changes are sufficient to fix the core dumps apparently caused by the changes made in nginx 1.23.0 concerning the internal representation of headers.

heikojansen avatar Aug 18 '22 15:08 heikojansen

I am one of those users that can confirm this resolves the crashes with nginx 1.23.1 .

tmcqueen-materials avatar Aug 18 '22 15:08 tmcqueen-materials

+1. We have been using the fix for two weeks now with no issues.

craig-riecke avatar Aug 30 '22 11:08 craig-riecke

Thanks so much @heikojansen - this looks great. I've rebased your changes on the latest master after updating the CI builds to build 1.23.x (requiring a newer compatible headers-more module also). Everything looks good so this is merged. Thanks again!

Thanks also to you both @tmcqueen-materials and @craig-riecke for your testing and insight.

davidjb avatar Dec 01 '22 13:12 davidjb