acme-companion icon indicating copy to clipboard operation
acme-companion copied to clipboard

Published 20 hours ago • verified publisher icon nginx-proxy

docker_api https fix for secured docker

Open alin-o opened this issue 5 years ago • 3 comments

The certificate path is also needed when docker daemon mode is tlsverify

see https://docs.docker.com/engine/security/https/#connecting-to-the-secure-docker-port-using-curl

alin-o avatar Jun 30 '20 17:06 alin-o

Hi.

Thanks for the contribution. Have you tested it ?

Do you think you could add documentation for this feature to your PR ?

buchdag avatar Jul 04 '20 00:07 buchdag

Hi,

I tested this on my own servers, which are configured with daemon mode tlsverify, and it works. Before this change, no certificates were ever generated because the curl command returned just an error message,

I added a short documentation under docs/Container-configuration.md. I hope it is the right place.

alin-o avatar Jul 04 '20 10:07 alin-o

I added a short documentation under docs/Container-configuration.md. I hope it is the right place.

Yep, that's perfect, thanks.

I tested this on my own servers, which are configured with daemon mode tlsverify, and it works.

Okay this is going to be pretty hard to test on Travis.

buchdag avatar Jul 04 '20 18:07 buchdag