Add option to use public_ip as hostname in inventory plugin

Open martialblog opened this issue 3 years ago • 4 comments

Hi,

this would add the option to use the public_ip as a hostname in the inventory plugin.

Cheers, Markus

Dec 09 '22 16:12 martialblog

I wasn't sure on how to write a test for that. I'd be happy to add a test if someone could give me a hint.

Dec 09 '22 16:12 martialblog

how does this work with IPV6 as it is introduced in ACS 4.17.x?

Dec 12 '22 20:12 rvalle

I suppose it won't. I specifically named it "v4_public_ip" in order to introduce a v6_public_ip in the future...

Dec 13 '22 07:12 martialblog

My question is that you are using instance.publicip and reexporting it as v4_public_ip.

In ACS 4.17 with IPV6 is it not possible that an IPV6 is returned as instance.public ip?

Just brainstorming, I have not reviewed the implementation or anything... but perhaps worth double checking...

Dec 13 '22 08:12 rvalle