Enji Cooper

> "kyua report" still give me the same error even with your newest patch. I suspect it's one of the cases involving the skipped or disabled status. Need to do...

As I suspected, the issue is that GTEST_SKIP is being called without a reason: ``` $ sudo kyua test -k /usr/tests/sys/fs/fusefs/Kyuafile write:Write.append write:Write.append -> skipped [0.017s] Results file id is...

Hmmm... that didn't work :/... ``` $ kyua report --results-file=/root/.kyua/store/results.usr_tests_sys_fs_fusefs.20190405-182049-970358.db kyua: E: Column 'result_reason' is not a string (sqlite db: /root/.kyua/store/results.usr_tests_sys_fs_fusefs.20190405-182049-970358.db). $ sqlite3 /root/.kyua/store/results.usr_tests_sys_fs_fusefs.20190405-182049-970358.db SQLite version 3.27.1 2019-02-08 13:17:39 Enter...

> Shouldn't that be allowed? If you don't supply a reason to `GTEST_SKIP`, shouldn't it use a sane default, like `""`? That’s what I’m trying to implement as a workaround,...

Ok. I'm starting to understand where the issue's coming from: ``` 192 static model::test_result 193 parse_result(sqlite::statement& stmt, const char* type_column, 194 const char* reason_column) 195 { 196 try { 197...

Well! It looks like `store/write_transaction.cpp:425-426` does the field NULLing for me :D! ``` 409 int64_t 410 store::write_transaction::put_result(const model::test_result& result, 411 const int64_t test_case_id, 412 const datetime::timestamp& start_time, 413 const datetime::timestamp&...

And... magic! ``` $ sudo kyua test -k /usr/tests/sys/fs/fusefs/Kyuafile write write:AioWrite.DISABLED_aio_write -> skipped: YOU HAVE 1 DISABLED TEST [0.004s] write:Write.DISABLED_direct_io_evicts_cache -> skipped: YOU HAVE 1 DISABLED TEST [0.004s] write:Write.DISABLED_mmap ->...

@jmmv: I realize this is a large change, but I was wondering if there's a way that I could work with you to get this change reviewed and into the...

@jmmv: ping?

@jmmv: ping?