Enji Cooper

Results 126 comments of Enji Cooper

It looks like the integration test failures were caused by environmental issues to me. Does that assessment seem correct? Is there a way to restart the failed jobs to help...

The PR is ready for review again. Thanks!

> @ngie-eign could you pls take another look on merge conflicts? I think this should be good to get in. Done--and this time I think it might stick 🤞. Please...

> [FAIL] [k8s.io] Container OOM runtime should output OOMKilled reason [It] should terminate with exitCode 137 and reason OOMKilled Joy. Another unrelated test reliability issue...

`git commit --amend` and force push (to force a rerun) results in another set of failures with some flaky tests: - A repeat of the previous failure: https://github.com/containerd/containerd/pull/11692#issuecomment-3260079525 . -...

Some of the reliability problems might be addressed (either fully or partially) by https://github.com/containerd/containerd/pull/12211 .

CI passed finally 🥅 !!!! ![](https://media4.giphy.com/media/v1.Y2lkPTc5MGI3NjExOHVxOGtlcWxiMmZicTF6Zjd6dWphdmNwZHMwdnlvOGwzbHhia3BwMSZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/gjCz74ilJCnLrGguht/giphy.gif)

And now `gmake check` is starting to fail on the branch with FreeBSD because I upgraded `golangci-lint` to the latest release 🙄... https://github.com/containerd/containerd/issues/12279 .