TWCManager icon indicating copy to clipboard operation
TWCManager copied to clipboard

Published 20 hours ago • verified publisher icon ngardiner

MQTT Fixes from Abstract

Open MikeBishop opened this issue 11 months ago • 13 comments

This PR attempts to pull out all the MQTT-related changes from #483, other than #492. This without #492 might be somewhat inconsistent.

Draft because I haven't explicitly tested this yet, just done the work in git to lift it out.

MikeBishop avatar Mar 16 '24 06:03 MikeBishop

I took a quick look and these changes are not compatible with paho mqtt client v2 and the MQTTv5 protocol. So this PR will probably only work for installs that are still using paho mqtt client v1.

I will fix this when I have more time.

RichieB2B avatar Mar 23 '24 07:03 RichieB2B

It turned out to be an easy fix, see https://github.com/RichieB2B/TWCManager/commit/69027ca4936320fc8ae10658bc211b9271d95c0a and the paho migration documentation for reference.

RichieB2B avatar Mar 23 '24 10:03 RichieB2B

Incorporated -- thank you!

MikeBishop avatar Mar 26 '24 14:03 MikeBishop

Looks good, thanks @MikeBishop and @RichieB2B

ngardiner avatar Mar 26 '24 22:03 ngardiner

I tried this merged into my working branch (main + some PRs) and it seems to be working. Appreciate it if someone else can give it a try before we merge.

MikeBishop avatar May 15 '24 21:05 MikeBishop