Ngan Pham comments

Repositories
Issues
Comments

Results 53 comments of


                                            Ngan Pham

[Fix #13351] Add Lint/NoRescueErrorMessageChecking rubocop to discourage rescue error matching

Just wanted to add some more context (I work with @simulk, at Gusto). This cop was extracted from our multi-million line Rails monolith. From what we've seen internally, pretty much...

Run danger without submitting a check status to GitHub

Happy to implement this if it’s ok. Posting this issue to see if there’s an existing way.

Gemfile require option allows you to require any file

I tried to implement this and got it working. However, it breaks gems like `rails`, which has a "meta-gem" that doesn't contain anything. The `lib/rails.rb` actually resides in the `railtie`...