hootenanny icon indicating copy to clipboard operation
hootenanny copied to clipboard

Linear Breakwater (BB041) translated to closed way in JOSM with Hootenanny import

Open tdvorakcaci opened this issue 3 years ago • 2 comments

Describe the bug Closed Breakwater_Line (BB041) converted to closed way in JOSM with Hootenanny import. Hootenanny export results in Breakwater_Area (BB041) and loss of Breakwater_Line feature.

To Reproduce Steps to reproduce the behavior:

  1. See screenshot below
  2. Import MGCP TRD v4.5.1 data with Hootenanny
  3. Export data with MGCP schema switcher with Hootenanny

Expected behavior Closed ways/lines maintain feature geometry on Hootenanny import/export

Screenshots Original MGCP Breakwater_L in MGCP TRD 4.5.1 image Imported Breakwater in JOSM image

Desktop (please complete the following information): N/A

Smartphone (please complete the following information): N/A

Additional context N/A

tdvorakcaci avatar Jan 30 '22 19:01 tdvorakcaci

In #5216 I have changed the internal schema so that a closed line breakwater will default to being a line feature on export. This means that the editor will need to add area=yes if they want a closed line to be an area feature. Importing an area breakwater automagically adds area=yes

This agrees with the OSM Wiki: man_made=breakwater

mattjdnv avatar Jan 31 '22 20:01 mattjdnv

In the v11.0.0 build of ME_JOSM we added an explicit area=yes or area=no to the presets for any FCODE that can be both a Line and an Area. https://github.com/ngageoint/hootenanny/pull/5189

This functionality will depend on the next release of Hoot to get this translation change not to strip area tags, https://github.com/ngageoint/hootenanny/pull/5201

brianhatchl avatar Jan 31 '22 20:01 brianhatchl