General Building (AL015) w/ FFN=Religious Activities & HWT=Chapel changed to FFN=Place of Worship

[MikeTho16]

Describe the bug In iD (probably happens in JOSM too) under the MGCP schema, if one maps a General Building(AL015) point feature with Feature Function (FFN) = Religious Activities, and sets the House of Worship Type (HWT) = Chapel, iD changes Feature Function (FFN) to Place of Worship. Under TRD, HWT is a valid, and required, field for FFN=Religious Activities.

To Reproduce Steps to reproduce the behavior:

1. Start iD editor (or press F5 to refresh so you are starting with a known state)

2. Draw a point

3. Make sure "Tag Schema:" is set to "MGCP"

4. Search for "building"
   

5. Select "General Building (AL015)"

6. Add field "Feature Function"

7. Set "Feature Function" to "Religious Activity"

8. Add field "House of Worship Type"

9. Set "House of Worship Type" to "Chapel"

10. "iD changes "Feature Function" to "Place of Worship"
    

11. HWT is required for FFN="Religious Activities"

Also happens with

• HWT=Cathedral
• HWT=Church
• HWT=Marabout
• HWT=Religious Community
• HWT=Mosque
• HWT=Pogoda
• HWT=Shrine
• HWT=Tabernacle
• HWT=Synagogue
• HWT=Stupa

Expected behavior

• Do not change FFN from Religious Activities to Place of Worship

Screenshots

• Embedded in “To Reproduce” section above.

Desktop (please complete the following information):

• OS: Ubuntu 16.04
• Browser: Firefox 85.0.1 (64 bit)
• iD Version: 2.17.3.----.5

Smartphone (please complete the following information):

• N/A

Additional context

• None

[mattjdnv]

I think refining the FFN assignment based on the HWT attribute is reasonable and the code should changed from the current IF HWT, Then FFN=931.

From the TRD:

When Feature Function FFN=930 (Religious Activities), FFN=931 (Place of Worship), every effort should be made to attribute as accurately as possible the House of Worship Type ‘HWT’

The two FFN's:

Religious Activities	930	Activities of religious organizations or individuals providing services either directly to worshippers (for example: in churches, mosques, temples, synagogues or other places of worship) or through the preparation of individuals for such service. ( Includes religious communities (for example: a convent or a monastery), religious retreats, and religious funeral service activities. )

Place of Worship	931	A place where religious worship is performed. ( Usually a building or similar structure is designed for this purpose. )

Looking at HWT I think that these values for FFN are applicable

• FFN=930 (Religious Activities): 6 (Minaret), 7 (Religious Community)
• FFN=931 (Place of Worship): 2 (Cathedral), 3 (Chapel), 4 (Church), 5 (Marabout), 9 (Mosque), 11 (Pagoda), 14 (Shrine), 15 (Tabernacle), 16 (Temple), 20 (Synagogue), 21 (Stupa)

[MikeTho16]

As part of GAIT there is a spreadsheet called MGCP_IllogicalAttributeEnumeration_V11_TRD4 that shows that all House of Worship Types are valid with both "Religious Activities(930)" and "Place of Worship(931)" FFNs

Also, "House of Worship Type(HWT)"="Religious Community(7)" is valid with "Community Center(893)", "Auditorium(892)", "Social Work(887)", "Institution(859)", and "Residence(563)."

[mattjdnv]

Same problem as #4737 See it for more discussion

[MikeTho16]

Tested today in JOSM 11.0.0, does not work (as expected as there was no comment in the ticket indicating otherwise):