AWR.Athena icon indicating copy to clipboard operation
AWR.Athena copied to clipboard

we shld def collab

Open hrbrmstr opened this issue 7 years ago • 4 comments

I had started https://github.com/hrbrmstr/metis a cpl weeks ago since one of the more overtly gnarly bits of athena is the auth (if you're not doing basic creds). i have no particular need to be the keeper of an Athena pkg (but i'd lobby for a quirky name like the greek god who was athena's helper :-). Maintaining my Apache Drill wrapper pkg is plenty of work on it's own. You folks jumping in here to fill a need is ++gd.

Package naming bias aside (it rly doesn't matter what the pkg is called) i do think the auth needs to be a seamless part of the pkg since there are so many ways to do so with AWS. it should also, likely, have support for non-default connection parameters (for some stuff at work I need to change some of them, hence my inclusion). Feel free to steal as little or as much from my scant populated nascent pkg start as you like.

CRAN is going to have a hissy fit abt the auto-dl of the driver. I'd suggest making (i was going to do this, too) either an athenajars pkg and keep it updated with the latest aws athena jar or an explicit message on failure to find driver paired with a downloader function.

i was also going to head down a path of dplyr integration, but one thing that needs to be taken care of for that is the schema naming inclusion and i'm not sure it's worth the effort in the short term.

when i'm back from vacation i'll gladly join in here with any PRs/help/etc.

hrbrmstr avatar Jun 16 '17 13:06 hrbrmstr

wrong button hit. meh.

It'd also be good to consider integrating this with @leeper's cloudyr https://github.com/cloudyr IMO. I have commit rights there so I can do that once this gets further along (if you are open to the idea)

hrbrmstr avatar Jun 16 '17 13:06 hrbrmstr

CRAN accepted the package today along with the autodownload :).

I'll defer to @daroczig about integrating with other cloud packages and authentication, I wrote the minimum amount of code I needed to move forward with another project at work.

nfultz avatar Jun 16 '17 22:06 nfultz

Ha ha nice. Just be prepared for them to catch it because they did that for one of my packages very recently and got it kicked off CRAN. On Fri, Jun 16, 2017 at 18:16 Neal Fultz [email protected] wrote:

CRAN accepted the package today along with the autodownload :).

I'll defer to @daroczig https://github.com/daroczig about integrating with other cloud packages and authentication, I wrote the minimum amount of code I needed to move forward with another project at work.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/nfultz/AWR.Athena/issues/6#issuecomment-309146960, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfHtoNkvYzNaSAwA7sSAxifQqeKcLAGks5sEv7PgaJpZM4N8cqN .

hrbrmstr avatar Jun 16 '17 22:06 hrbrmstr

Hi Bob,

good to see you again :) Happy to collaborate on this and other related projects as well, although the current shape of the package serves our immediate needs at least for now. But let's discuss the potential next steps after you get back from vacation.

Some quick feedback until then:

  • Regarding package name: I'm also pretty proud of the idea of coming up with an AWR pkg family as per https://twitter.com/daroczig/status/839516169035886592 :)
  • Regarding CRAN: I had a conversation on this with the CRAN maintainers back in February, when I submitted the first AWR package (~60 MB jar), and installing the jar files from an external location at installation time was preferred a lot over submitting a separate data/jar package to CRAN

Best, Gergely

daroczig avatar Jun 16 '17 23:06 daroczig