nfs-ganesha icon indicating copy to clipboard operation
nfs-ganesha copied to clipboard

Is Travis still used?

Open abitrolly opened this issue 8 months ago • 10 comments

I see https://github.com/nfs-ganesha/nfs-ganesha/blob/next/.travis.yml but I don't see its build status indicator in https://github.com/nfs-ganesha/nfs-ganesha/blob/next/README.md?plain=1

Is it still used?

abitrolly avatar Mar 15 '25 05:03 abitrolly

Travis was used by CEA, one of the long-time contributors to Ganesha. They haven't been active in several years, but we've been keeping their code (they were the primary consumer of 9-p) building. So I'm not aware of anyone using Travis currently, but it's possible.

dang avatar Mar 17 '25 13:03 dang

@dang do you mean @phdeniel and @lieb? Hey guys, do you still use Travis? :D

I see no CI reports in GitHub. How nfs-ganesha is being tested nowadays?

abitrolly avatar Mar 17 '25 14:03 abitrolly

We use centos-ci as our CI. See https://github.com/nfs-ganesha/ci-tests/tree/centos-ci

dang avatar Mar 17 '25 14:03 dang

Also, we use gerrithub for reviews, so that CI doesn't show up on github.

dang avatar Mar 17 '25 14:03 dang

@dang I haven't tried, but I believe it is possible for centos-ci to set commit status on GitHub for checked hashes. So that https://github.com/nfs-ganesha/nfs-ganesha/commits/next/ could link at CI jobs.

abitrolly avatar Mar 17 '25 14:03 abitrolly

Also, we use gerrithub for reviews, so that CI doesn't show up on github.

Go team have some automation to pair GitHub with Gerrit transparently. Haven't looked into that.

abitrolly avatar Mar 17 '25 14:03 abitrolly

Sure, back in the day but I've been retired since 2014. All my work is down in a paleolithic layer near the dinosaurs... Except for historical research, ignore anything Travis and follow the advice given above.

lieb avatar Mar 17 '25 16:03 lieb

I'm sure it's possible, but the full request/review/CI/commit cycle for us is done via gerrithub, so we've never looked into it. I'm not sure what we'd even check against, since we don't use PRs here.

dang avatar Mar 17 '25 16:03 dang

Why the Gerrit is preferred for reviews? What features does it have that GitHub/GitLab don't.

abitrolly avatar Mar 18 '25 08:03 abitrolly

The big feature is continuity of changes in PRs. When someone reviews a patch, and you update it, gerrit shows you the difference between the old version of the PR and the new version of the PR. When we started using Gerrit, GIthub didn't do that at all. Now, github sort of does that, and it more or less works if you only make local changes to your PR. However, if you rebase the PR as well, you get tons of extraneous changes. Gerrit can separate those out.

Regardless, we've been using gerrithub for years, so we're unlikely to change unless github starts providing something useful that gerrithub does not.

dang avatar Mar 18 '25 15:03 dang