svg-pathdata icon indicating copy to clipboard operation
svg-pathdata copied to clipboard

Fix type export

Open alecmev opened this issue 3 years ago • 1 comments

Proposed changes

This package currently works in Node.js because it's bundled, so there are no relative imports, and in "moduleResolution": "node" TypeScript (the default) because it doesn't care about the file extensions. But now there's "moduleResolution": "Node16" which does enforce the presence of the extensions, and there are relative imports in declaration files, so it breaks.

Builds on top of https://github.com/nfroidure/svg-pathdata/pull/70.

Code quality

  • [ ] I made some tests for my changes
  • [ ] I added my name in the contributors field of the package.json file

License

To get your contribution merged, you must check the following.

  • [x] I read the project license in the LICENSE file
  • [x] I agree with publishing under this project license

alecmev avatar Aug 21 '22 13:08 alecmev

@alecmev thanks for this. I'm currently moving all my modules to ESM so I'll just check if it suits the way I did it in my other repos. I think I'll have some time to review it in a week. In the meanwhile I asked a review from other contributors.

nfroidure avatar Aug 29 '22 10:08 nfroidure