Nicolas Froidure comments

Results 82 comments of


                                            Nicolas Froidure

Consider using URI template at the Whook's core

Closing in favor of https://github.com/nfroidure/whook/issues/118

Troubleshooting Github access

Same here, followed the docs to setup locally but it doesn't work. The "Sign in with GitHub" button that links to `http://localhost:5173/auth/login` just redirect me to the login page `http://localhost:5173/login`....

allow empty array for generateStaticParams

Returning an empty array is legit in some cases like here for pagination to point out the fact there is no page 2 and still avoid to create a `/blog/page-1`...

Merge improvements (pitch bend, <s>`parseSong()`</s> song parsing, ...) from my private repo

Switching this repo to GNU GPL v3 is also an option for me.

Mutualize compilation of OpenAPI schemas

Almost done with https://github.com/nfroidure/whook/commit/1b014669398f8f74da06f973f0c1d0a6d41a2953 but leaving open to remind the tasks left.

Use correct pitch-bend range

@page200 this repository is meant to be used per other libraries and is just providing a midi file reader. Best practices is not to copy/paste the code but use the...

Resetting `playTime`

Thanks for helping here, feel free to PR a fix, I'll merge asap.

Async error with readme example

Thank for the report, feel free to PR a change.

Async error with readme example

Fixed by https://github.com/nfroidure/gulp-svgicons2svgfont/pull/62 @timint thanks for contributing

fix: allow to opt out of area dot fallback

Since I could workaround the problem, I let maintainers see if it is still relevant if so, I can update the PR with the breaking change or just close it...