Nicolas Frisby

Results 77 issues of Nicolas Frisby

The existing Consensus interface used by the node code to create `BlockForging` structures (eg upon init and SIGHUP) that are then passed to Consensus does not obviously suffice for the...

Karl witness https://hydra.iohk.io/build/7851335/nixlog/4 on PR input-output-hk/ouroboros-network#3380, which is surprising because the PR's contents seems totally unrelated. I'm therefore assuming it's a flaky failure, but this Issue is to at least...

technical debt

Taken from https://github.com/IntersectMBO/ouroboros-consensus/pull/808#issuecomment-1954913114, upon clicking the "Merge when ready" button. - [x] s-r-p stanzas (see https://github.com/IntersectMBO/ouroboros-consensus/pull/808#discussion_r1490714381) - [ ] Either move the GSM logic into the ChainDB and keep the...

good first issue
technical debt

For example, I removed the replication of the Immutable/VolatileTip acquire messages, since the test is so simple that the number of those is currently irrelevant---it's misleading to replicate them, as...

no changelog

This constructor https://github.com/IntersectMBO/ouroboros-consensus/blob/437d7160079c83c4632fe0a42c596e5105c59a4d/ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Serialisation/Common.hs#L184-L190 and this data type https://github.com/IntersectMBO/ouroboros-consensus/blob/437d7160079c83c4632fe0a42c596e5105c59a4d/ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Serialisation/Common.hs#L196-L198 can currently together express a situation in which any of the HFC eras can be disabled. Similar to `NodeToNode`. (Edit: but PR...

technical debt

This is just stub --- need to double-check if there is already a better Issue for this. https://github.com/IntersectMBO/ouroboros-consensus/blob/4c0a421d187478f9f740d27521b682988d843596/sop-extras/src/Data/SOP/Index.hs#L173-L182

technical debt

**Internal/External** *Internal* **Describe the feature you'd like** The deserialization of the ledger snapshot file should fail if what was read from disk differs from what was written to disk (eg...

enhancement
good first issue

@karknu shared an unexpected observation on pooltool.io. A pool had a large number of concentrated "slot/height battles" (ie short forks) listed on pooltool.io, and moreover it won nearly all of...

documentation

A microbenchmark investigation of the benefits of `readTVarIO` versus `atomically . readTVar`. See the directory's `README.md` for the motivation.

documentation

Key changes: * Add `GetLedgerConfig :: Query blk (LedgerConfig blk)` * Make `SerialiseNodeToClient blk (LedgerConfig blk)` a superclass of `SerialiseNodeToClientConstraints` * This makes sense now that the Node-to-Client protocol includes...