nfrechette
feat(decompression): improved ACL asserts when initializing a decompression_context
After running into an issue where ACL was failing to initialize the decompression_context, I noticed that ACL already has the info for why the initialization failed in the error_result, we just weren't showing it in the assert
Small change to the initialize and relocate functions that adds more useful info to the asserts when possible
Sorry, only just realised that ACL targets C++11! I'll need to rewrite this to not use if constexpr
Good stuff! Thank you for the contribution. It looks like appveyor CI is failing because the VM instances are slower than before, somehow and we time out. We'll ignore it for now and I'll see if I can fix that later.
Apologies for the slow reply, once CI completes, I'll merge this. Thank you for your contribution, it is much appreciated :)
@nfrechette it looks like appveyor might have timed out again? Seems like all the individual builds passed
Yeah, appveyor has been struggling. The builds had been hovering around 50-55mins for some time now, and it looks like a configuration change on their end pushed it over the 1h limit. I'll have to disable some of the slower tests with the older vs2015 toolchain which is fine since it's so ancient now.
Thank you for the contribution!
![allcontributors[bot] avatar](https://avatars.githubusercontent.com/in/23186?v=4 "Published by a pub.dev verified publisher"){kind=small}