nflverse-rosters icon indicating copy to clipboard operation
nflverse-rosters copied to clipboard

Include Spotrac player IDs in roster.csv

Open nickwan opened this issue 2 years ago • 6 comments

Hello, can yall please have Spotrac ID support available somewhere to join on? The spotrac ID looks unique to their site (i.e. Larry Fitzgerald's Spotrac ID is 966, while his NFL ID is 2506106, esb ID is FIT437493, gsis ID is 00-0022921, and college ID is 2927)

Alternatively, if you ingest salary info into a roster file that would also be cool. bonus points for draft day info

nickwan avatar Apr 23 '22 04:04 nickwan

IDs shouldn’t be too tricky aside from the usual name join BS. Contract data definitely a bit more involved.

Is OTC better than spotrac to store?

tanho63 avatar Apr 25 '22 15:04 tanho63

I wrote a scraper that scrapes historical contract data from sites like this https://overthecap.com/contract-history/quarterback/ image

Data will look like this: image

I think the OTC IDs are not the same as spotrac IDs. Do you guys think this data is valuable in the nflverse @tanho63 and @nickwan? We could automate the scraper and add a function in nflreadr to load all historical contracts.

mrcaseb avatar Apr 25 '22 15:04 mrcaseb

100% useful!

tanho63 avatar Apr 25 '22 15:04 tanho63

scraping all positions results in ~31k contracts fwiw

mrcaseb avatar Apr 25 '22 15:04 mrcaseb

I wrote a scraper that scrapes historical contract data from sites like this https://overthecap.com/contract-history/quarterback/ image

Data will look like this: image

I think the OTC IDs are not the same as spotrac IDs. Do you guys think this data is valuable in the nflverse @tanho63 and @nickwan? We could automate the scraper and add a function in nflreadr to load all historical contracts.

The current version of this data is now attached to this release https://github.com/nflverse/nflverse-data/releases/tag/otc_contract_data

mrcaseb avatar Apr 25 '22 21:04 mrcaseb

Update: after some discussion about naming it's now actually here lol https://github.com/nflverse/nflverse-data/releases/contracts

Still TODO: gsis/nflverse id -> otc id

tanho63 avatar Apr 26 '22 11:04 tanho63