nflverse-pbp icon indicating copy to clipboard operation
nflverse-pbp copied to clipboard

drive_start_yard_line str formatting

Open nickwan opened this issue 4 years ago • 1 comments

the column drive_start_yard_line has some inconsistencies between yrdln:

['50', '', 'WAS20', 'NYJ20', 'ATL20'] where the format from yrdln is three-letter-abbr and the yard line with a space in between.

the column drive_start_yard_line also has a few inconsistencies, albeit much smaller: ['50', '']

obviously there's an easy bandage to fix this, but unsure if the str formatting in the processing pipeline is truncating strings for some reason

nickwan avatar Sep 14 '20 03:09 nickwan

The drive variables are mostly us passing along info provided by nfl in the data, so I'm guessing that's the actual values, but can check later. We haven't paid a lot of attention to the drive stuff because it's extremely buggy on nfl's end

On Sun, Sep 13, 2020, 23:15 Nick Wan [email protected] wrote:

the column drive_start_yard_line has some inconsistencies between yrdln:

['50', '', 'WAS20', 'NYJ20', 'ATL20'] where the format from yrdln is three-letter-abbr and the yard line with a space in between.

the column drive_start_yard_line also has a few inconsistencies, albeit much smaller: ['50', '']

obviously there's an easy bandage to fix this, but unsure if the str formatting in the processing pipeline is truncating strings for some reason

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/guga31bb/nflfastR-data/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK37TPJ7FFBJEFX46U7733SFWDE7ANCNFSM4RLCG2GA .

guga31bb avatar Sep 14 '20 12:09 guga31bb