nfl_data_py icon indicating copy to clipboard operation
nfl_data_py copied to clipboard

Published 20 hours ago • verified publisher icon nflverse

Fix DataFrame indexing - import_ids()

Open brendanillies opened this issue 1 year ago • 0 comments

First time doing this so bear with me!

Function import_ids() was using an incorrect DataFrame indexing method - namely specifying set vs. list. Added type conversion as well as a default case of returned columns ret_columns to remove multiple lines of redefining the df variable. Also added passing test cases around the change and added test case caching to be ignored.

brendanillies avatar Oct 01 '23 19:10 brendanillies