Nico Flaig
Nico Flaig
> So yes there is a bug in the implementation, but not in the createElapsedTimeTracker. That one seems to be good as what is intended for, it's just tracking time...
> So if the error appears in first 1 minute of creation of the provider it will not be logged this is not true, there is even a test case...
You can reduce the frequency of sending data by increasing the [interval](https://github.com/gobitfly/eth2-client-metrics-exporter/blob/988698bfb5124d658d7fc6275ded6111737cab97/main.go#L71), which can be configured by providing the following CLI flag `--interval 5m`, this would then only sent data...
Noticed something else, running `yarn lint` before `yarn check-types` causes no issues. But if `check-types` is executed once locally, any lint runs will fail with the following ``` /home/nico/projects/ethereum/lodestar/packages/light-client/test/unit/webEsmBundle.browser.test.ts 1:1...
> lint test which are depending upon the build artifacts this is such a bad design, lint should never depend on build...and it never has until now. Also right now...
> So in paractivce it's not slowing down 2x. I meant by 50% but it's more like 25-30%, this is still bad enough imo
Issue seems to be resolved, having a smooth DX on unstable branch now, thanks @nazarhussain :heart:
Just a note, this test is really old and never failed when we used mocha, it started to get flaky after vitest migration.
@divyesh87 Thanks for looking into this, we can achieve the same without modifying the `Date` global ```diff diff --git a/packages/validator/test/unit/utils/clock.test.ts b/packages/validator/test/unit/utils/clock.test.ts index dfa9d386e6..b5ef2ab1fa 100644 --- a/packages/validator/test/unit/utils/clock.test.ts +++ b/packages/validator/test/unit/utils/clock.test.ts @@ -90,6...