react-helmet icon indicating copy to clipboard operation
react-helmet copied to clipboard

primaryAttributeKey check for string

Open asifrahman001 opened this issue 3 years ago • 1 comments

If tag[primaryAttributeKey] is not string, it should return false. Since, In many cases we have tag[primaryAttributeKey] as object.

We get this error if the attr is an object TypeError: tag[primaryAttributeKey].toLowerCase is not a function at /node_modules/react-helmet/lib/HelmetUtils.js:124:100 at Array.filter (<anonymous>) at /node_modules/react-helmet/lib/HelmetUtils.js:100:22 at Array.reduce (<anonymous>) at getTagsFromPropsList (/node_modules/react-helmet/lib/HelmetUtils.js:97:18) at reducePropsToState (/node_modules/react-helmet/lib/HelmetUtils.js:181:19)

asifrahman001 avatar Dec 23 '21 18:12 asifrahman001

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Asif Rahman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 23 '21 18:12 CLAassistant