react-helmet icon indicating copy to clipboard operation
react-helmet copied to clipboard

npm prepublish script is not runnable during npm link

Open kelvien opened this issue 4 years ago • 1 comments

Do you want to request a feature or report a bug? Bug

What is the current behavior? I use react-helmet on both my local dependency and my app. I linked my dependency using npm link and I have to link react-helmet too so that I don't create a duplicate instance of react-helmet in my code. But linking react-helmet in my dependency throws this error when I ran npm link.

> [email protected] build /workspace/app/node_modules/react-helmet
> rollup -c

Error: ENOENT: no such file or directory, lstat '/workspace/dep/node_modules/react-helmet/rollup.config.js'
    at Object.realpathSync (fs.js:1529:7)

The files needed to be prepublish-ed are not included in npm. See .npmignore

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React and react-helmet. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

  • run npm link ../dependency/node_modules/react-helmet

What is the expected behavior?

  • prepublish script does not block user from linking the module locally There are many solution, but I can't tell which is better since I don't know the process your team is using to publish this module.

Which versions of React and react-helmet, and which browser / OS are affected by this issue? Did this work in previous versions of React and/or react-helmet? react-helmet 6.0.0

kelvien avatar May 24 '20 01:05 kelvien

This an own configuration/usage requirement....

The files needed to be prepublish-ed are not included in npm. See .npmignore

If you require the source then use the git repo in your package.json tagged on the source you want. Caution you will have to do everything yourself/

AubreyHewes avatar Oct 09 '20 02:10 AubreyHewes