react-helmet icon indicating copy to clipboard operation
react-helmet copied to clipboard

refactor: port Helmet to TypeScript with TSDX

Open doctyper opened this issue 5 years ago • 2 comments

Description

This PR migrates React Helmet to TDSX. It attempts a minimal amount of changes to ensure backwards compatibility with Helmet v6:

  • Adds Prettier support
  • .js files have been renamed to .ts(x)?
  • Code was kept as intact as possible
  • Replaces Mocha/Karma with Jest
  • Retains all 236 existing tests
  • Test file syntax has been migrated from Chai to Jest
  • Replaces Travis with GitHub Actions

A $FIXME type was added to set up types with minimal code disruption. The refactor should be considered complete when no $FIXME types remain in source code.

doctyper avatar Apr 12 '20 20:04 doctyper

Why has this stalled? Would love to see this landing. Do you need help?

pamapa avatar Jun 11 '21 10:06 pamapa

Also happy to contribute to getting this over the line if required.

AnthonyCrowcroft avatar Apr 20 '22 21:04 AnthonyCrowcroft