react-helmet
react-helmet copied to clipboard
nfl
Add placement prop to allow for placement at the top of the head
I believe this is failing due to https://github.com/nfl/react-helmet/pull/482
Please let me know what I can do to get this moving, if the approach is something you like, etc.
I really need something like this as well. Is there any update on getting this in?
Codecov Report
Merging #484 into master will increase coverage by
0.01%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 96.91% 96.92% +0.01%
==========================================
Files 3 3
Lines 292 293 +1
==========================================
+ Hits 283 284 +1
Misses 9 9
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/HelmetUtils.js | 96.88% <0.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9e5cca1...4f3e806. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cwelch5 I see that you've merged a couple PRs lately, I merged master in here so tests are passing now. Is there any way we could get this (or something like it) merged or should I see if any other
libraries have made progress since I last checked in November 2019?
Hey friends! Do you have any updates about this PR? This feature would be a very useful one. 🙌
One workaround for this could be placing the title tag with data-react-helmet="true" property as following:
<head>
<title data-react-helmet="true"></title>
...
</head>
The generated tag preserves it's top-placement.
This is so important for canonical urls, charsets, ... Please merge this in.
@swalberg @LGCambra @frankenthumbs @benashkan @beningo @cwelch5
Please either start managing the PRs or open a process to transfer the library to some other organization.
@swalberg @LGCambra @frankenthumbs @benashkan @beningo @cwelch5 Bumping as @MariaAbadi is right
Hi guys any update on whether we could progress this one? Still an issue now :(
