Nate Fischer

Results 81 issues of Nate Fischer

See [the coverage report](https://codecov.io/gh/shelljs/shelljs/src/c16fb7dac9dfec6cec29cfe633daece83a127d47/src/chmod.js) We're currently missing line coverage for: - [non-existent file](https://github.com/shelljs/shelljs/blob/master/src/chmod.js#L107) - [recursing on symbolic links](https://github.com/shelljs/shelljs/blob/master/src/chmod.js#L111) - Using `=` to [set permissions exactly](https://github.com/shelljs/shelljs/blob/master/src/chmod.js#L173) - Unrecognized operator (default case...

test coverage

I ran our test suite on my local Windows 7 machine. Although all our tests pass or skip on appveyor, I see some local test failures (please ignore the `cmd.js`...

chore
Windows

Also inspired by #833. `ln -s` is weird in that the semantics differ depending on whether it's given a relative path or an absolute path. For example: ```sh $ touch...

test
test coverage

Coffeescript moved on npm. `coffee-script` ➡️ `coffeescript` (no hyphen).

chore

Originally discussed with @bruce-one on #727, shifting the discussion to a dedicated issue. While ShellJS aims to be cross-platform, it's often impossible to support posix behavior while also operating on...

feature

Not sure why we're calling `path.resolve()` on [this line](https://github.com/shelljs/shelljs/blob/master/src/which.js#L91), but I don't think it's correct. If we're given a correct absolute path, then we should return the absolute path. If...

fix
help wanted
breaking
test coverage

It's probably a good idea to refactor `mkdir()` and make sure we accommodate all the error codes listed in [the man page](http://man7.org/linux/man-pages/man2/mkdir.2.html). I think a much better approach (after checking...

fix
refactor
bash compat

Exposing ShellStrings through the plugin API could pave the way for interesting plugins. ShellStrings are currently somewhat modifiable by creating a new command with the `canReceivePipe` attribute (the command gets...

refactor
low priority

Currently, `sed()` and `grep()` return multiline strings. I think they should instead return arrays. This is to stay consistent with `ls()`'s behavior. This should be resolved before v1.0

low priority

I'm an engineer on the Android WebView team. It recently came to my attention that you're using WebViewLocalServer (probably forked from https://github.com/google/webview-local-server). Instead of forking this class, we strongly recommend...