Nate Fischer comments

Results 340 comments of


                                            Nate Fischer

Move shjs into a separate package

Actually, we may just deprecate and remove shjs. I don't think this binary has strong advantages over using bare `node`. I'd rather just stop maintaining this entirely.

Consistent error handling in ShellJS

> Slashes should be consistent cross-platform Should consider the [slash](https://github.com/sindresorhus/slash) module.

Force link behaves differently than on OS X

Thanks for reporting! Confirmed on Linux too. The relevant code is here: https://github.com/shelljs/shelljs/blob/9035b27403c7e3c3dc801939d20dec8fe6143c06/src/ln.js#L38-L44 I think `fs.unlinkSync()` does the right thing (don't follow links), but `fs.existsSync()` is wrong (it does follow...

Add interactive user input method

We would probably implement this as `shell.read`, which would be analogous to the bash builtin `read`. There was another bug which was related to piping the process stdin to shelljs...

Add interactive user input method

Vaguely related to https://github.com/shelljs/shelljs/issues/18#issuecomment-181772671. That issue is a feature request for `cat('-')`.

The result of `shell.ls('XXX/')` is not equal to `ls XXX/`

Thanks for reporting this. I'll look into this.

The result of `shell.ls('XXX/')` is not equal to `ls XXX/`

Unfortunately, I don't have time to look at this. If another community member is able to investigate, I'm happy to provide advice and guidance in the codebase.

Destination dirname used in calculation of resolvedSourcePath?

We could probably do better to document this in the code. Let's keep this issue open to add some explanatory comments. This issue has to do with relative symlinks, which...

Improve tests for ln -s with relative source arguments

Another thought regarding code coverage: how good is our coverage for *other* utilities handling broken links? For example, does `rm('-r')` do the right thing if there's a broken link in...

which() should not call path.resolve()

We're also missing coverage for this line, so that should be resolved as part of this fix. Letting this block #671