humps icon indicating copy to clipboard operation
humps copied to clipboard

Published 20 hours ago • verified publisher icon nficano

fix(types): correctly set __all__

Open sk- opened this issue 1 year ago • 2 comments

Status

READY

Description

The all package attribute must contain string elements, but I made a mistake in https://github.com/nficano/humps/pull/277/files and set them to objects.

Without this change, mypy fails with and without implicit reexport.

Related PRs

https://github.com/nficano/humps/pull/277/files

Todos

  • [ ] Tests
  • [ ] Documentation

Deploy Notes

Notes regarding deployment the contained body of work. These should note any db migrations, etc.

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

git pull --prune
git checkout <feature_branch>
pytest

Impacted Areas in Application

List general components of the application that this PR will affect:

sk- avatar Aug 30 '22 22:08 sk-

Pull Request Test Coverage Report for Build 2959951128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2932923128: 0.0%
Covered Lines: 79
Relevant Lines: 79
💛 - Coveralls

coveralls avatar Aug 30 '22 22:08 coveralls

Looking forward to seeing this released!

ZdenekM avatar Sep 15 '22 11:09 ZdenekM

Is this project still maintained @nficano ?

iteal avatar Oct 04 '22 03:10 iteal

Is this project still maintained @nficano ?

Yes, sorry about that! I have a couple projects I'm juggling simultaneously. If you or anybody else is interested in becoming a maintainer, please let me know!

nficano avatar Oct 20 '22 18:10 nficano