mfcuk icon indicating copy to clipboard operation
mfcuk copied to clipboard

No check to see if the card is actually a mifare 1K/4K

Open baconwaifu opened this issue 8 years ago • 1 comments

Using a mifare classic mini causes a segfault as the program is expecting a tag type of 0x8 or 0x18, not 0x9.

the main thread is not checking for get_trailer_block_for_sector() to return MIFARE_CLASSIC_INVALID_BLOCK and segfaults.

A solution would be a simple sanity check:

if (block == 0xFFFFFFFF) {
    printf("The card is not a Mifare Classic card");
    return 1;
}

baconwaifu avatar Jan 05 '17 21:01 baconwaifu

is there any workaround to use mfuck with Mifare Classic mini ? regards

revok7512 avatar Feb 14 '17 10:02 revok7512