Noah Fahlgren
Noah Fahlgren
Nice! Nextflow (or another workflow engine like Parsl, Snakemake, etc.) is part of our roadmap for upgrading `plantcv-workflow.py` Our main goals with using an existing workflow engine are 1) scalability,...
`tmp_dir` is not a required input, it can be left as `None`. When you run `plantcv-workflow.py` and `tmp_dir` is set to `None` it uses the `tempfile` package to make a...
I think this sounds good overall. It's a good thing, but we will have to include tests for each script module since they would be part of the package. There's...
`plantcv` is shorter, but not sure if it creates confusion because it's the name of the package too, so `plantcv-cli` could avoid that issue. What do you think?
I might have to do a little research/thinking on testing. I think unlike our normal modules we can't (completely) test the individual components of each program (i.e. we can't really...
By combining these into one program we will reduce a little bit of overlapping code between them. And luckily all the heavy lifting code is already being tested in the...
I could imagine three potential implementations: 1. New calibration input to `analyze_*` functions (downside is more inputs = bad) 2. When a calibration function is run the calibration value(s) are...
I haven't looked at this from every angle yet but here's what I have so far. Using OpenCV 3.4.10 I reproduce the incorrect first image above. In that version `cv2.COLOR_BayerBG2BGR`...
I ran through 3.4.2, 3.4.4, 3.4.7, 3.4.8, and 3.4.9 from conda-forge and 3.4.2.17, 3.4.4.19, 3.4.7.28, 3.4.8.29, 3.4.9.33, 3.4.10.37, 3.4.11.45 from PyPI and can confirm that with BG2BGR for 3.4.2 and...
I was hoping to look back at the build logs to see exactly what version tests were running on but because we switched platforms I don't seem to have access...