Noah Fahlgren

Results 121 comments of Noah Fahlgren

The original behavior was to include subdirectories, so this wasn't a breaking change, simply a new option to exclude them. But correct that we're missing the flag to control this...

That was my thinking unless you or other folks think they're useful still

Hi @AdamDimech! The blob files (e.g. `blob49`) on our system are zip files containing a file called `data`. Our data files are raw 8-bit binary files. The data encoded in...

FWIW I ran a raw image through the three methods in colour-demosaicing. The bilinear algorithm gave visually similar results to the OpenCV bilinear method. The Malvar and Menon methods also...

Structural similarity index comparisons: OpenCV bilinear vs colour-demosaicing bilinear: 0.99711175070708258 OpenCV bilinear vs OpenCV EA: 0.99442848407307005 OpenCV bilinear vs OpenCV VNG: 0.82513981615385668 ![comparison](https://user-images.githubusercontent.com/6233508/93378957-c40d3d80-f822-11ea-806d-e5d46e32dc96.png)

For sure! OpenCV bilinear vs colour-demosaicing Malvar: 0.93852859491338958 OpenCV bilinear vs colour-demosaicing Menon: 0.90777965142929185 ![comparison2](https://user-images.githubusercontent.com/6233508/93387596-1bb1a600-f82f-11ea-9fcf-d1d66b1bd9a4.png)

I guess I really need a matrix of SSIM comparisons :)

`pcv.readbayer` reads a grayscale Bayer filter image file at the moment. We could plug it into the process if we convert the `data` file to one of these images first...

Hi @SethPolydore, I suggest refactoring the line causing the error in the `tests.py` file to: ```python spmask = pcv.color_clustering_segmentation(img=img, project_name=os.path.join(TEST_DATA, "temp_testing_multi")) ``` `os.path.join` will use the appropriate OS-specific file path...

We do still use pytest but the command is somewhat different. It's what you added to the PR review guide, found in this section: https://plantcv.readthedocs.io/en/latest/pr_review_process/#step-4-review-the-tests There's some flexibility depending on...