react-rainbow icon indicating copy to clipboard operation
react-rainbow copied to clipboard

fix: CurrencyInput has pattern that does not allow numbers with decimals

Open jeduardo824 opened this issue 1 year ago • 0 comments

  • [X] I have searched the issues of this repository and believe that this is not a duplicate.

Describe the bug

PS: I know this component is in Beta state, just reporting to put it on the radar if it is not yet.

The CurrencyInput has a pattern="\d*" (here) that is not allowing numbers with dots or commas.

##Screenshots

image

To Reproduce 🕹

Steps to reproduce the behavior:

  1. Create a form
  2. Use the CurrencyInput component
  3. Digit a number > 999 or with decimal parts
  4. The input validation will raise an error about the format of the number

Expected Behavior 🤔

No error is thrown

Current Behavior 😯

Form validation raises an error asking to provide a value matching the specified format

Context 🔦

Create a form that will ask for the value of something in dollars.

Your Environment 🌎

NextJS application with Formik

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version 113

Possible Solution I don't think this format is needed, so maybe just remove it or create a pattern that allows dots and commas

jeduardo824 avatar Jun 04 '23 16:06 jeduardo824