nextui icon indicating copy to clipboard operation
nextui copied to clipboard

fix: Input should not change value itself when value props is set (fix #737

Open sun0day opened this issue 2 years ago • 2 comments

Closes #737

📝 Description

The controlled Input value should not be changed by Input when value prop is set.

⛳️ Current behavior (updates)

When a non-undefined value prop is passed to Input, the changeHandler and clearHandler internal code will directly call setSelfValue to change value.

🚀 New behavior

When a non-undefined value prop is passed to Input, the changeHandler and clearHandler internal code will not call setSelfValue to change value.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

sun0day avatar Sep 06 '22 03:09 sun0day

@sun0day is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 06 '22 03:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextui-storybook ✅ Ready (Inspect) Visit Preview Nov 5, 2022 at 8:02PM (UTC)

vercel[bot] avatar Sep 06 '22 03:09 vercel[bot]

Can we please merge this? @jrgarciadev

OrhanTozan avatar Oct 02 '22 15:10 OrhanTozan