nextui icon indicating copy to clipboard operation
nextui copied to clipboard

refactor(docs): default import -> named import

Open TroyTae opened this issue 2 years ago • 9 comments

Closes #579

📝 Description

Refactor import code in document

💣 Is this a breaking change (Yes/No):

No

TroyTae avatar Jul 05 '22 21:07 TroyTae

Codecov Report

Merging #601 (8cccb06) into main (10c4c25) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files         223      223           
  Lines        3501     3501           
  Branches     1105     1105           
=======================================
  Hits         2618     2618           
  Misses        868      868           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 05 '22 21:07 codecov-commenter

@TroyTae is this change related to React 18.0.0? Just out of curiosity.

danielsimao avatar Jul 06 '22 08:07 danielsimao

@danielsimao As I wrote here(https://github.com/nextui-org/nextui/discussions/579), it's related to React 17!

ghost avatar Jul 06 '22 08:07 ghost

Hey @TroyTae sorry, could you please fix the conflicts?

jrgarciadev avatar Aug 28 '22 20:08 jrgarciadev

@TroyTae is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 29 '22 09:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextui-storybook ✅ Ready (Inspect) Visit Preview Aug 29, 2022 at 2:44PM (UTC)

vercel[bot] avatar Aug 29 '22 09:08 vercel[bot]

@jrgarciadev Done!

ghost avatar Aug 29 '22 09:08 ghost

Hey @TroyTae thank you!, I forgot to mention to you that for it to work we have to modify the transformCode function https://github.com/nextui-org/nextui/blob/main/apps/docs/src/components/playground/utils.ts#L9-L42 which is a mini transpiler that I wrote to join sandpack with react-live,

I'm getting this error because of that:

Screen Shot 2022-08-29 at 09 43 09

jrgarciadev avatar Aug 29 '22 12:08 jrgarciadev

@jrgarciadev Oops I'm so sorry I'm just added react hooks into react-live scope

ghost avatar Aug 29 '22 14:08 ghost

@jrgarciadev Are there some additional issues blocking of this?

ghost avatar Oct 05 '22 11:10 ghost