nextui icon indicating copy to clipboard operation
nextui copied to clipboard

[BUG] - Modal scroll is not blocked in mobile Safari

Open TroyTae opened this issue 3 years ago • 2 comments

Describe the bug

Modal scroll is not blocked in mobile Safari. overflow: auto; is a frequently used way, but I think it is better to block it with js.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

  1. Open modal in safari
  2. Try scroll outside
  3. Scroll is not blocked

Expected behavior

Scroll need to be blocked

Screenshots or Videos

https://user-images.githubusercontent.com/20078201/175798823-9dc8452c-889f-4acc-97c7-6effb012e6cd.mp4

Operating System Version

iPadOS

Browser

Safari

TroyTae avatar Jun 26 '22 04:06 TroyTae

I was only able to find a library that handled this edge case: React Spectrum.

I don't know if @jrgarciadev would allow a refactor of the component to use useDialog from react-aria instead.

danielsimao avatar Jul 01 '22 16:07 danielsimao

Hey guys, the migration of this component to react-aria is in progress, it should be available in the next release v10, it should fix this issue

jrgarciadev avatar Jul 02 '22 22:07 jrgarciadev