fix(navbar): allow height prop to accept number type and fix broken menu

[FacundoTenuta]

📝 Description

Navbar menu breaks when passing a custom height of type number. This PR fixes the issue by converting the height to pixels if it is a number.

⛳️ Current behavior (updates)

Fixed the mentioned error. Now, we can pass custom height as either a number or a string without breaking the navbar menu.

🚀 New behavior

The height parameter can be provided as a number, which will be automatically converted to pixels, or as a string. This ensures the navbar menu remains intact regardless of the input type.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No additional information

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of the height property in the navbar component to prevent layout issues when specifying a numerical height value.

• New Features

  • Enhanced robustness of the --navbar-height CSS variable assignment by ensuring it always receives a valid pixel format for numerical values.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: e0564e7e1c184fed83efe52be807a0d1b84ca2d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/navbar	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel[bot]]

@FacundoTenuta is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

The changes made to the NavbarMenu and useNavbar components improve the handling of the height property for the navbar's CSS variable. By introducing type checks, numeric heights are converted to pixel strings, enhancing the robustness of the components and preventing potential runtime errors. This ensures more consistent styling behavior across the navbar, ultimately leading to a more reliable user interface experience.

Changes

Files	Change Summary
.../navbar/src/navbar-menu.tsx	Enhanced height handling in inline styles to ensure valid CSS values by converting numbers to pixel strings.
.../navbar/src/use-navbar.ts	Modified the assignment of --navbar-height to format numeric heights correctly, improving styling integrity.
.changeset/healthy-clouds-refuse.md	Introduced a patch for the @nextui-org/navbar component to convert numerical height values to pixels, preventing layout issues.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[awesome-pro]

@FacundoTenuta kindly add following in your PR

1. changeset (run pnpm changeset)
2. screen-recording/screenshot to issue before change
3. solution after change

[FacundoTenuta]

@wingkwong Sorry for the oversight. The changeset has been added and is now up to date.