fix(link): deprecated onClick warning on using onPress
Closes #3196
📝 Description
Fixed the console warning onClick is deprecated, please use onPress on using onPress with Button as Link
Add a brief description
⛳️ Current behavior (updates)
https://github.com/user-attachments/assets/0d5bdc9a-b9a4-410a-a43d-782e70ca80fe
🚀 New behavior
https://github.com/user-attachments/assets/7651d4cd-2d73-4a12-8590-1973fa3b5641
💣 Is this a breaking change (Yes/No): No
📝 Additional Information
Summary by CodeRabbit
-
Bug Fixes
- Resolved a warning related to deprecated functionality in the link component, enhancing stability and reliability.
-
New Features
- Updated the link component to utilize an improved accessibility hook, enhancing compatibility and user experience.
🦋 Changeset detected
Latest commit: 6424d8dd00ceadd7f51ae73f8fa283444a4d1113
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @nextui-org/link | Patch |
| @nextui-org/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@abhinandan-verma is attempting to deploy a commit to the NextUI Inc Team on Vercel.
A member of the Team first needs to authorize it.
Walkthrough
This update introduces a patch for the @nextui-org/link library to address a deprecated onClick warning, replacing it with onPress for better compliance with current best practices. Additionally, the import statement for the useLink functionality was changed to source from @nextui-org/use-aria-link, reflecting a shift in its implementation. These changes enhance the library's reliability and compatibility, particularly regarding accessibility features.
Changes
| File | Change Summary |
|---|---|
| .changeset/red-ducks-greet.md | Introduced a patch for @nextui-org/link to eliminate deprecated onClick warnings. |
| packages/components/link/src/use-link.ts | Changed import for useLink from @react-aria/link to @nextui-org/use-aria-link. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Got "onClick is deprecated, please use onPress" ( #3196 ) | ✅ |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@wingkwong sir updated @react-aria/link to the latest version, currently no new update available.
Can you explain a bit what you meant in step 2
updated @react-aria/link to the latest version, currently no new update available.
both statement are contradicted
Can you explain a bit what you meant in step 2
This is not step 2. I mean if there is a new version of @react-aria/link and it doesn't work. Then sync the difference back to our custom package @nextui-org/use-aria-link.
Just checked myself. No new logic introduced in RA side. Good to use @nextui-org/use-aria-link back.