fix(checkbox, switch, radio): double click need in chrome after double click outside

[awesome-pro]

Closes #3528

📝 Description

After clicking twice outside checkbox(or switch or radio), it needed to be double clicked for toggle thereafter only in Chrome. added select-none in their css to prevent user: select and it solved the issue :)

In the recordings below I have used double click in outside region when taking the pointer aside. First video needed double click to toggle while second one needs single click only.

I tried to use ripple extension but it did not work , so ripple effect is not visible, however u can figure out from time lapse.

⛳️ Current behavior (updates)

https://github.com/user-attachments/assets/bd6338b4-feb3-4ef1-b467-73d551be78f1

🚀 New behavior

https://github.com/user-attachments/assets/4e224c97-f9c3-49d4-8db5-916d722840d8

💣 Is this a breaking change (Yes/No): NO

📝 Additional Information

Summary by CodeRabbit

• Bug Fixes
  • Resolved navbar height issue for improved visual consistency and layout.
  • Fixed double-click requirement for checkboxes, switches, and radio buttons in Chrome, allowing for single-click interaction.
• User Experience Enhancements
  • Added select-none class to checkbox, radio, and toggle components to prevent unintended text selection during interactions.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 670a48a52c2cc79c771d1c470ee8330765596389

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel[bot]]

@abhinandan-verma is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

The recent updates to the @nextui-org/theme package focus on enhancing user interaction with the navbar and form components, addressing issues such as common usability problems in checkboxes, switches, and radio buttons. Key changes include resolving a double-click issue in Chrome to allow single-click activation and enhancing visual behavior by preventing text selection in checkbox, radio, and toggle components. These modifications aim to improve overall user experience and interface consistency.

Changes

Files	Change Summary
.changeset/brown-days-applaud.md	Fixed navbar height issue with h-full class, improving layout consistency.
.changeset/sweet-crabs-buy.md	Resolved double-click issue for checkbox, switch, and radio button components in Chrome, enabling single-click activation for improved usability.
packages/core/theme/src/components/checkbox.ts, packages/core/theme/src/components/radio.ts, packages/core/theme/src/components/toggle.ts	Added select-none class to prevent text selection during interaction, enhancing usability for checkbox, radio, and toggle components.

Assessment against linked issues

Objective	Addressed	Explanation
Checkbox click behavior change after double clicked disable checkbox items (#[3528])	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 26, 2024 0:58am