fix: remove autoCapitalize to prevent Firefox warning
Closes #3297
📝 Description
This bug occurs because react-aria sets autoCapitalize: 'off' on each segment of the DateInput , but in Firefox, it defaults to 'none'. This discrepancy between server side rendering and client-side rendering results in a warning. In Safari and Chrome, it remains 'off', so no warning is displayed. Since the DateInput has input-mode=numeric, which already shows a numeric keyboard, the autoCapitalize setting is unnecessary.
⛳️ Current behavior (updates)
A warning is displayed when rendering a component with DateInput in Firefox.
🚀 New behavior
No warning is displayed.
💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
Summary by CodeRabbit
- Bug Fixes
- Removed the
autoCapitalizefeature from the DateInputSegment component to resolve compatibility issues in Firefox.
- Removed the
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nextui-docs-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 3, 2024 0:37am |
| nextui-storybook-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 3, 2024 0:37am |
🦋 Changeset detected
Latest commit: 508086dc6127c0cbce793105b64624a528dba201
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
| Name | Type |
|---|---|
| @nextui-org/date-input | Patch |
| @nextui-org/date-picker | Patch |
| @nextui-org/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Walkthrough
A patch was introduced to the @nextui-org/date-input package, specifically modifying the DateInputSegment component. The primary change was the removal of the autoCapitalize prop due to compatibility issues with Firefox, resolving a bug where server and client prop values differed.
Changes
| File Path | Change Summary |
|---|---|
packages/components/date-input/src/date-input-segment.tsx |
Removed autoCapitalize prop to resolve server-client mismatch issues in Firefox and updated export declaration. |
.changeset/chatty-pianos-run.md |
Documented the patch introducing the removal of autoCapitalize to prevent warnings |
Sequence Diagram(s)
N/A
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Resolve Prop autoCapitalize did not match issue in Firefox (#3297) |
✅ |
[!TIP]
AI model upgrade
gpt-4omodel for reviews and chat is now liveOpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
In linear, it was v2.5.0, but v2.4.3 certainly looks good. I will leave the rest to Junior to decide.