fix(select): close select by pressing selector button

[wingkwong]

Closes #3276

📝 Description

• pass domRef to ariaShouldCloseOnInteractOutside instead so that clicking selector button won't trigger the incorrect logic.

⛳️ Current behavior

pressing select button won't close the select (if open)

🚀 New behavior

pr3374-demo.webm

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

• Bug Fixes

  • Resolved the issue where the select component would close unexpectedly when interacting with the selector button.

• Tests

  • Added test cases to verify the opening and closing behavior of the select listbox when clicking the selector button.

[linear[bot]]

ENG-1020 [BUG] - Select not able to close when clicked on again

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 30, 2024 11:34am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 30, 2024 11:34am

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 727a229f7aab56cf17e7be830400a1194c8e5684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/select	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai[bot]]

Walkthrough

The patch introduces a fix for the @nextui-org/select package to address the issue where the select menu does not close when the selector button is clicked again. Changes include modifying the Select component test cases to ensure proper interactions and updating the useSelect function to correct the logic for menu closure.

Changes

File	Change Summary
.changeset/curvy-students-judge.md	Added a patch note for fixing the select closing issue with the selector button (#3276).
packages/components/select/__tests__/select...	Updated tests for the Select component to include default selected keys and test the opening/closing behavior of the listbox.
packages/components/select/src/use-select.ts	Revised the logic in useSelect function to use domRef instead of triggerRef and simplified dependencies for getInnerWrapperProps.

Sequence Diagram(s)

Not applicable as the changes are relatively straightforward, focusing on minor logic updates and test modifications.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure the select menu closes when the selector button is clicked again (#3276)	✅
Test that the select listbox opens and closes correctly when interacting (#3276)	✅
Update the useSelect function to correct closing logic based on references (#3276)	✅

---

[!TIP]

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[webinoo]

Why is this still happening on mobile in 2.6.10 ?