nextui icon indicating copy to clipboard operation
nextui copied to clipboard

fix(user): avatar icon not shown in user

Open awesome-pro opened this issue 1 year ago • 4 comments

Closes #3369

📝 Description

Fixed the bug to show the default avatar icon, when no name(prop) is passed inside avatarProps

⛳️ Current behavior (updates)

Screenshot 2024-06-30 at 1 41 54 PM

🚀 New behavior

Screenshot 2024-06-30 at 1 39 25 PM Screenshot 2024-06-30 at 1 40 49 PM

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

removed the code passing name(of user) to avatarProps

Summary by CodeRabbit

  • Bug Fixes
    • Improved user component by ensuring the name property is correctly assigned to the avatar only when no avatar icon source is provided.

awesome-pro avatar Jun 30 '24 08:06 awesome-pro

🦋 Changeset detected

Latest commit: 90c4bdcefd7f89850463c21859b1fb06d76cd0ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/user Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 30 '24 08:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 8:31am

vercel[bot] avatar Jun 30 '24 08:06 vercel[bot]

@abhinandan-verma is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 30 '24 08:06 vercel[bot]

Walkthrough

The changes resolve a bug where the User component incorrectly rendered the avatar initial even when an avatar icon was provided. The fix involves updating the useUser function to stop passing the name property to the avatarProps when an avatar icon is used. Additionally, new tests are added to ensure the correct behavior by importing AvatarIcon and using it in the test cases.

Changes

Files Change Summary
packages/components/user/src/... Removed name property from avatarProps if the type is not a string.
packages/components/user/__tests__/... Added import statement for AvatarIcon; modified test case; added new test.

Sequence Diagram(s)

Not applicable as the changes are mainly bug fixes and internal adjustments rather than new features or significant modifications to control flow.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Update useUser to stop passing name to avatarProps when avatar icon is provided (#3369)
Ensure default avatar icon renders correctly (#3369)

[!TIP]

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 30 '24 08:06 coderabbitai[bot]