nextui icon indicating copy to clipboard operation
nextui copied to clipboard

[BUG] - Popover's arrow should combine with the border line of the box

Open chen-yan opened this issue 1 year ago • 3 comments

NextUI Version

v2.4

Describe the bug

image

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

  1. render popover component 2.set showArrow value as true
  2. click button.

Expected behavior

image

Screenshots or Videos

No response

Operating System Version

MacOS Windows

Browser

Chrome

chen-yan avatar Jun 11 '24 09:06 chen-yan

@wingkwong I want to work on the issue #3235 , I want to know How can I update the code of Popover component to display the arrow. (This will be my first contribution to this repo)

const App = import {Popover, PopoverTrigger, PopoverContent, Button} from "@nextui-org/react";

export default function App() { return ( <Popover placement="bottom" showArrow={true}> <PopoverTrigger> <Button>Open Popover</Button> </PopoverTrigger> <PopoverContent> <div className="px-1 py-2"> <div className="text-small font-bold">Popover Content <div className="text-tiny">This is the popover content </PopoverContent> </Popover> ); }`;

const react = { "/App.jsx": App, };

export default { ...react, }; `

awesome-pro avatar Jun 24 '24 22:06 awesome-pro

Hi @wingkwong I have raised a PR for this fix. Please review it when you have the time :)

arindam1997007 avatar Jun 25 '24 01:06 arindam1997007

Closing - after an internal discussion, we'll keep the original design as it is.

wingkwong avatar Jul 06 '24 14:07 wingkwong