fix(input): added hover and focus to input when label placement is outside-left #2328

[ShrinidhiUpadhyaya]

Closes #2328

📝 Description

When clicked or hovered on the label with outside-left placement, input doesn't get focus and no hover effect.

⛳️ Current behavior (updates)

https://github.com/nextui-org/nextui/assets/8769408/f135464d-167a-4595-884f-f769670b92b3

🚀 New behavior

https://github.com/nextui-org/nextui/assets/8769408/13610199-072b-4e8d-a6b9-0f75a96c430a

💣 Is this a breaking change (Yes/No):

📝 Additional Information

• const {isHovered, hoverProps} = useHover({isDisabled: !!originalProps?.isDisabled}); can also be renamed as const {isHovered: isInputHovered, hoverProps: inputHoverProps} = useHover({isDisabled: !!originalProps?.isDisabled}); so the hover variables can be easily identified for the input and the label.

• If the PR gets accepted please use my GitHub email-id ([email protected]) instead of my other email-id for the Co-authored-by: message.

Summary by CodeRabbit

• Bug Fixes
  • Improved hover and focus behaviors for input labels when placed outside-left.
  • Enhanced label interaction by enabling pointer events on them.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 45bdab4174291b8c7e3dea57ce40168c787c15f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@nextui-org/input	Patch
@nextui-org/autocomplete	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 12, 2024 8:06pm

[vercel[bot]]

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

This patch addresses issues with the hover and focus behavior of the @nextui-org/input module, particularly when labels are placed outside-left. It introduces a new hover state for labels, updates data attributes for hover states, and modifies label style definitions to enhance pointer event handling.

Changes

File Path	Change Summary
.changeset/lucky-schools-travel.md	Patch introduction for hover and focus issues with outside-left label placement.
.../components/input/src/use-input.ts	Added isLabelHovered state; updated data-hover attributes; adjusted label dependency list.
.../core/theme/src/components/input.ts	Updated label style definition to include pointer-events-auto.

Assessment against linked issues

Objective	Addressed	Explanation
#2328: Input should focus when clicking on outside-left label placement.	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.